Get the benchmark compiling / running again

julienschmidt / go-http-routing-benchmark

Go HTTP request router and web framework benchmark

BSD 3-Clause "New" or "Revised" License

1.65k stars 238 forks source link

Get the benchmark compiling / running again #65

Closed theckman closed 5 years ago

theckman commented 8 years ago

put dependencies under glide management, will make it easier to keep this benchmark functional.
disable benchmarking the echo framework
- The Echo framework has changed a bunch of its interfaces, and no longer implements http.Handler in doing so. As such, Echo no longer works within this framework.
disable the rivet framework
- In testing, the rivet framework was returning 200s but the body was always empty. This looks to be an issue within rivet and less to with the benchmark

theckman commented 8 years ago

The echo thing is arguably that I was mildly lazy when working on this and didn't feel like rewriting all of its usage. If you'd like me to fix it instead of disable it, I cant try to spend some time getting it working here. Although, thinking about it quickly it may end up being a shim around the package itself which may impact the benchmarks.

Let me know!

julienschmidt commented 5 years ago

The current master is using Go modules and is compiling again. Thanks a lot anyway!