search

julienschmidt / go-http-routing-benchmark

Go HTTP request router and web framework benchmark
BSD 3-Clause "New" or "Revised" License
1.65k stars 238 forks source link

Add Rivet to testing #8

Closed achun closed 10 years ago

achun commented 10 years ago

Rivet -- https://github.com/typepress/rivet

julienschmidt commented 10 years ago

1) Please keep the tests alphabetically sorted 2) Rivet obviously contains code copied from HttpRouter. Please respect the license: https://github.com/julienschmidt/httprouter/blob/master/LICENSE This includes retaining the copyright notice of HttpRouter

achun commented 10 years ago

Yep, The Rivet is inspiration from HttpRouter, but the code is rewrite for Rivet. I am happy to retaining the copyright notice of HttpRouter.

https://github.com/typepress/rivet#acknowledgements https://github.com/typepress/rivet/blob/master/LICENSE

julienschmidt commented 10 years ago

Thanks. You might want to change https://github.com/typepress/rivet/blob/master/LICENSE#L18 which currently states that only I am not liable for any damage :) Usually a "based on" notice is more clear.

The next round is planned in ca. 11 days.