search

juliensobrier / Net-Google-SafeBrowsing4

Net::Google::SafeBrowsing4 - Perl library for Google Safebrowsing v4
Apache License 2.0
2 stars 4 forks source link

Better error handling needed when requesting full hashes fails #7

Closed papaiatis closed 7 years ago

papaiatis commented 7 years ago

When I call $gsb->lookup(...) sometimes I see this message in the logs: Full hash request failed but my client software keeps working because the lookup method returns an empty array back, thus I don't really have the chance to catch this error.

I would expect this method to either throw an exception or return back an error flag in cases of this.

juliensobrier commented 7 years ago

last_error is now updated when the full hash request fails