julieth756 / share-extras

Automatically exported from code.google.com/p/share-extras
0 stars 0 forks source link

Translated train-times to Swedish and to use api:s for swedish railways #13

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Since the swedish api:s did not support the "via" parameter this one was 
removed in this version. For the moment the module is hosted at github: 
https://github.com/acando/train-times-sweden

Another difference is that I'm using the maven-alfresco lifecycle by 
@mindthegabz to build this extension.

I have really not looked to much into what it would take to make the original 
extension generic enough to take a country parameter, and depending on that use 
the api for that country. 

Original issue reported on code.google.com by bille...@gmail.com on 26 Apr 2011 at 5:37

GoogleCodeExporter commented 9 years ago
Are you happy for this code to be incorporated into the original dashlet? I 
cannot see a license specified on the github page, but Share Extras is Apache 
2.0 so it would need to be compatible with that.

Original comment by will.abson on 27 Apr 2011 at 9:03

GoogleCodeExporter commented 9 years ago
Of course I will specify the license - sorry for missing that. 

I have now checked in a license-file stating Apache 2.0.

The current state of the dashlet can not be incorporated in the original 
dashlet codebase in an easy way since the apis differs, the swedish version 
does for example not have the "via" parameter. The easiest way would be to 
check this one in as a new add-on "Swedish train times". Maybe I would have to 
convert it to the ANT way of building to adhere to the other dashlets? On the 
other hand, maybe it would be nice to have one dashlet built the maven way for 
demonstration purposes? I did for example refine the maven build process to 
include the yui-compress library as a plugin. This way the js-code gets 
compress in the same way as the ANT dito.

WDYT?
/Erik

Original comment by bille...@gmail.com on 27 Apr 2011 at 9:24