search

juliocesar / rack-noie

A Rack middleware to redirect (*cough* kick) IE6 users out of your website
25 stars 12 forks source link

Not sure this works in Rails 3.2 #6

Closed noctivityinc closed 11 years ago

noctivityinc commented 11 years ago

Running Rails 3.2.12 with Ruby 1.9 and get this when visiting from IE:

!! Unexpected error while processing request: undefined method `each' for "Fail browser is fail":String

noctivityinc commented 11 years ago

btw - I have this in application.rb

config.middleware.use Rack::NoIE, {:redirect => "noie", :minimum => 9}

juliocesar commented 11 years ago

Hey! This middleware was written at a different age. An age when men and browser were enemies and violence was the only resource.

Nowadays, there are significantly better solutions, such as Chrome Frame, or even feature detection and graceful degradation / progressive enhancement. I strongly recommend you avoid this gem altogether and go for one of the aforementioned solutions. I keep this gem around for historical reasons only.

Thanks!

noctivityinc commented 11 years ago

You're crazy man. There is a movement happening. A movement to remove IE8 and below from this world. A movement to make development better for mankind. Just look at Jquery 2.0.0! Noie is a critical gem in the battle!

Sent from my iPad

On Apr 22, 2013, at 1:17 AM, Julio Cesar Ody notifications@github.com wrote:

Hey! This middleware was written at a different age. An age when men and browser were enemies and violence was the only resource.

Nowadays, there are significantly better solutions, such as Chrome Frame, or even feature detection and graceful degradation / progressive enhancement. I strongly recommend you avoid this gem altogether and go for one of the aforementioned solutions. I keep this gem around for historical reasons only.

Thanks!

— Reply to this email directly or view it on GitHub.

juliocesar commented 11 years ago

Haha, yeah, I subscribe to that thinking. But if a blunt instrument is to be applied, it better be Chrome Frame then. You know, the first hit is free. That way we get everyone hooked in Chrome.

noctivityinc commented 11 years ago

True dat. I just send them to a page like this and be done with them - http://wecora.com/noie

Sent from my  iPhone

On Apr 22, 2013, at 7:16 PM, Julio Cesar Ody notifications@github.com wrote:

Haha, yeah, I subscribe to that thinking. But if a blunt instrument is to be applied, it better be Chrome Frame then. You know, the first hit is free. That way we get everyone hooked in Chrome.

— Reply to this email directly or view it on GitHub.