search

juliomalegria / python-craigslist

Simple Craigslist wrapper
MIT No Attribution
387 stars 117 forks source link

Include body and images #45

Closed bschlenk closed 6 years ago

bschlenk commented 7 years ago

Add another option to get_results called include_details which also fetches the body of the listing as well as the urls of all the images. The listing is only fetched once and reused for both the geotag logic and the include_details logic.

juliomalegria commented 7 years ago

This is awesome! I love this idea. Do you mind syncing with head? I've done some changes.

bschlenk commented 7 years ago

Just synced! Should be good to pull in now.

juliomalegria commented 7 years ago

Thanks Brian again for this! Just a couple of comments I had before merging this in (see in-line comments).

bschlenk commented 7 years ago

Can you take a look at this again? I force pushed to my own repo, I'm not sure what the usual convention is for pull requests. I probably should have been doing this on a branch to begin with.

DavidWittman commented 6 years ago

@juliomalegria Bump. I'd like to use this feature too!

lekv commented 6 years ago

I'd like to have that too. @juliomalegria - Any way I could help?

indigobuffalo commented 6 years ago

+1, would be great to have this.

juliomalegria commented 6 years ago

Sorry for the long delay! Thanks @bschlenk for the changes. There's just one tiny issue which is that when there's only one image, there'll be only one link, instead of being repeated, so the current code will skip it.

I'll merge this now, and then do that small fix. Thanks a lot!