search

juliomalegria / python-craigslist

Simple Craigslist wrapper
MIT No Attribution
387 stars 117 forks source link

CraigslistForSale does not actually support auto_transmission filter #51

Closed sfc-gh-lrobles closed 6 years ago

sfc-gh-lrobles commented 6 years ago

Was reading through your code and I saw in your readme, it says auto_transmission is a filter you can pass to car searches, however that option isnt available

juliomalegria commented 6 years ago

auto_transmission, as well as other category specific filters are obtained from scrapping the site. That's why you couldn't find it in the code.

All the filters that show when you run CraigslistForSale.show_filters(category='cta') should be supported.

sfc-gh-lrobles commented 6 years ago 
CraigslistForSale(site='sfbay', category='cta', filters={'query': 'Honda', 'auto_transmission': 'manual'})
'm' is not a valid option for auto_transmission
'a' is not a valid option for auto_transmission
'n' is not a valid option for auto_transmission
'u' is not a valid option for auto_transmission
'a' is not a valid option for auto_transmission
'l' is not a valid option for auto_transmission
CraigslistForSale(site='sfbay', category='cta', filters={'query': 'Honda', 'auto_transmission': 1})
'1' is not a valid option for auto_transmission
'1' is not a valid option for auto_transmission
juliomalegria commented 6 years ago

See 2nd example in "Examples" for a query using category-specific filters. Putting 'manual' in a list should do the trick:

CraigslistForSale(
    site='sfbay', category='cta',
    filters={'query': 'Honda', 'auto_transmission': ['manual']}
)