search

julius383 / audio-nerve

Music identification and discovery
4 stars 0 forks source link

Add code for comparing similarity of two audio fingerprints #2

Closed julius383 closed 4 years ago

julius383 commented 4 years ago

This is more or less a transliteration of the Python code I wrote on chroma tests. I'd like some suggestions on what to use for testing out that the two implementations are compliant i.e what's the idiomatic way of writing tests in TS/node?

hipstermojo commented 4 years ago

I may need a diagram to better help me understand the comparison program. Nonetheless, concerning testing, any testing framework is fine given that this code runs synchronously. I would use Jest.

hipstermojo commented 4 years ago

The image helps clear up my confusion. Making testing suites for this would probably need you to either:

  1. "Cheat" by making fingerprint sequences and matching them against the fingerprint of the full song. It would be cheating since it does not help with changing the accuracy of the comparison metric.

  2. Fuzzing the comparison algorithm since you're just doing math on arrays,

Not sure how useful this input is to helping with the testing issue overall

julius383 commented 4 years ago

Thinking about it a bit I think I'll probably go with option 2