search

julius383 / audio-nerve

Music identification and discovery
4 stars 0 forks source link

Add code for fetching metadata #5

Closed julius383 closed 4 years ago

hipstermojo commented 4 years ago

Everything seems fine. I wonder why your tsconfig.json needs to also support DOM in the lib option. Is that because of Axios?

hipstermojo commented 4 years ago

When returning null from fetchMetadata maybe it can return a 404 if the song does not exist. Because I'm not sure what res.json(null) will look like when being sent.

hipstermojo commented 4 years ago

Is it possible to get the music label that released a song as well in the metainfo?

julius383 commented 4 years ago

Everything seems fine. I wonder why your tsconfig.json needs to also support DOM in the lib option. Is that because of Axios?

Yes that is because of axios

julius383 commented 4 years ago

When returning null from fetchMetadata maybe it can return a 404 if the song does not exist. Because I'm not sure what res.json(null) will look like when being sent.

Alright I'll fix that

julius383 commented 4 years ago

Is it possible to get the music label that released a song as well in the metainfo?

That would be a little tricky because of how the musicbrainz API is structured i.e differences between a release and a recording

hipstermojo commented 4 years ago

Is it possible to get the music label that released a song as well in the metainfo?

That would be a little tricky because of how the musicbrainz API is structured i.e differences between a release and a recording

Well I can just omit it since it seems like it may slow down the server to do more processing than is needed