search

juliusHuelsmann / st

Repatch repository of developed 'Vim Browse' and 'Alpha Focus Highlight' patches for simple terminal (st).
https://st.suckless.org/patches/alpha_focus_highlight/
MIT License
28 stars 11 forks source link

fix: do not reset terminal colors when focus/unfocus #18

Closed glpub closed 4 years ago

glpub commented 4 years ago

when using scripts which changes shell's default ANSI colors like base16-shell then focus/unfocus should not reset foreground colors to default ones

glpub commented 4 years ago

Thanks for the contribution :) You're absolutely right, I didn't consider that.

That's ok, nobody can know every aspect of the software :)

In case you encounter an error / have a feature proposal for one of the patches in the future, it might be easier for you to work directly on the patch - specific - branch (which does only contain the current version of the applied alpha-highlight or vim patch respectively), as on my master branch, I also have some additional custom changes (including other patches from the ST patches page) applied to my st build which may cause problems that do not originate from the patch / fix itself but from one of the other applied patches and hence distract when devising new changes.

My own private st repository has a bunch of patches applied, so to me easier to fork your repo and make pull request from them. Actually spent a time to apply vimBrowse patch to master st branch. If you would like I could try to make pull request for that too.

juliusHuelsmann commented 4 years ago

Sure, if you e.g. detect any bugs or want to work on a feature / port the current version of the patch to a more recent release of ST or the like, your contribution is very welcome :)