search

juliuscanute / qr_code_scanner

QR Code Scanner for Flutter
BSD 2-Clause "Simplified" License
999 stars 759 forks source link

fix: platform break changes #512

Closed xeinebiu closed 2 years ago

xeinebiu commented 2 years ago

Fix for the issue https://github.com/juliuscanute/qr_code_scanner/issues/511

SwiftyFlow commented 2 years ago

this still didn't help. cannot run on android simulator... about to remove this dependency but to replace with what?

xeinebiu commented 2 years ago

@SwiftyFlow please post some logs. What exactly did not run ?

juliansteenbakker commented 2 years ago

This issue is currently only existent on the MASTER channel of Flutter so i still need to test if this change doesn't break the STABLE channel.

xeinebiu commented 2 years ago

This issue is currently only existent on the MASTER channel of Flutter so i still need to test if this change doesn't break the STABLE channel.

Most probably the stable version won't be compatible with this change.

Maybe an alpha version should be released, or we simply wait for the next stable version of Flutter, test it and then maybe merge?

srmncnk commented 2 years ago

Can confirm that this works on master tip. The problem right now is that flutter introduced: 1) breaking changes in native Android code 2) bad obfuscation code in stable and beta branch. Fix for both is in master, so you can see how this complicates things.

I would very much appreciate an alpha version.

aaassseee commented 2 years ago

Hi @juliansteenbakker, any idea when will this pull request getting merged?

juliansteenbakker commented 2 years ago

Sorry for the slow response, but LGTM !