juliuscanute / qr_code_scanner

QR Code Scanner for Flutter
BSD 2-Clause "Simplified" License
999 stars 759 forks source link

[FEATURE] Lower minSdkVersion to 19 #635

Open BBQRIBS72 opened 1 year ago

BBQRIBS72 commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently the minSdkVersion set on this package is 20 - which is the sdk version used by Android 4.4w. The 'w' stands for 'wear' and this sdk version only contained updates for wearable devices (e.g. watches). There is no reason why the minSdkVersion of this package can't be 19 (the version used in android 4.4).

You can check the android SDK Platform release notes here: https://developer.android.com/studio/releases/platforms#4.4

There will be no functional change to the package. It will only mean that any project using the package can have a minSdkVersion of 19 rather than 20, making apps useable on more devices.

Describe the solution you'd like Only 1 line in 1 file needs to be changed: in android/build.gradle, line 35 should be changed from: minSdkVersion 20 to minSdkVersion 19

This change can also be made in the example/android/app/build.gradle so that you can test to see it works. I have forked the branch and tested it myself and the package loses no functionality.

Thanks

BraveEvidence commented 1 year ago

This will help https://www.youtube.com/watch?v=w-n0jUrUtPI&list=PLQhQEGkwKZUqZC2QAp_u4ZAzqpsCCRvmM&index=10 https://www.youtube.com/watch?v=QpnVENc9dIA&list=PLQhQEGkwKZUqZC2QAp_u4ZAzqpsCCRvmM&index=11