juliusgambe / pe

0 stars 0 forks source link

[FunctionalBug] Local part of email does not allow duplicate special characters #2

Open juliusgambe opened 11 months ago

juliusgambe commented 11 months ago

Bug Report:

Local part of email does not allow duplicate special characters that is stated in the error message. ie. - + . - Due to rarity, this will be a severity Low, however, it is not VeryLow as it the error message states the requirements wrongly.

Expected Output

Successful insertion of contact

Actual Output

Screenshot 2023-11-17 at 4.20.37 PM.png

Steps To Reproduce

  1. Open the app
  2. Key in add n/John Doe p/98765432 e/john++d@example.com g/CS2103T

Other Information

System Information

Item Description
Chip Apple M1 Pro
Memory 16 GB
Display 1920 x 1080
Operating System macOS Sonoma 14.0
Java Version 11
Terminal iTerm

nus-pe-bot commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Ambiguous format of Special Characters allowed in local-part of Email

Under Email field of a contact, there is the following constraint:

  1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.

The following command is entered: add n/testagain p/1234 e/email++yeet@gg.com

Expected: A new contact is created Actual: Error message on email constraints is given.

This could be a potential confusion for users when they need to input emails that contains multiple special characters

image.png

Another test is conducted with the following command and it worked: add n/waterson p/1234 e/email+yeet+waterson@gg.com

image.png

Users may be confused by the email constraint message. Perhaps a better error message or better explanation in User Guide and Developer Guide could resolve this.


[original: nus-cs2103-AY2324S1/pe-interim#3992] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** As per the definition, of a functionality bug: ![Screenshot 2023-11-21 at 12.36.09 PM.png](https://raw.githubusercontent.com/juliusgambe/pe/main/files/1b9d7801-ed27-470e-9517-7b395c9b8262.png) It being a functionality bug is more glaring as your error message contradicts the error message (it's suppose to allow the special characters but it didn't when you put multiple) and it wasn't documented in the UG (Behaviour not specified): ![Screenshot 2023-11-21 at 12.37.03 PM.png](https://raw.githubusercontent.com/juliusgambe/pe/main/files/0ac1d2aa-ff19-40ff-bb09-681649c1a3d8.png)