juliusgambe / pe

0 stars 0 forks source link

[FeatureFlaw] Name does not allow certain special characters #3

Open juliusgambe opened 9 months ago

juliusgambe commented 9 months ago

Bug Report:

Unable to key in certain special characters such as / where names such as John s/o Doe exist.

Expected Output

Successfully add the name in.

Actual Output

Screenshot 2023-11-17 at 4.26.41 PM.png

Steps To Reproduce

  1. Open app
  2. Key in add n/Johns/oDoe p/98765432 e/johnd@example.com g/CS2103T

Other Information

System Information

Item Description
Chip Apple M1 Pro
Memory 16 GB
Display 1920 x 1080
Operating System macOS Sonoma 14.0
Java Version 11
Terminal iTerm

soc-pe-bot commented 9 months ago

Team's Response

We recognise this is a flaw in our features, but this would be an issue for a small portion of users only, as people with S/O in their names (or other special characters) may be saved and identified using the other parts of their name. This is especially true in a student-targeted app where students are unlikely to save the full legal name of their friends in their contact list. Thus, rectifying this issue is not as important (based on the effort considerations, since it might be harder to change the other functions that rely on the name of the contacts, such as Find Person) as the work that has been done already.

As such, we are categorising this as a featureflaw that is out of scope because from a certain point of view, it could be a suboptimal design. 1. The UG specifies this constraint. 2. When the user attempts to add a second person with the same name, the software gives a suitable error message, this meets the requirements for an out of scope response.

Thank you so much for the feedback!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]