Open juliusgambe opened 9 months ago
Thank you for the feedback. However, we chose to allow users to delete users by name instead of index as the names are unique and it is much more convenient if you do have an address book of a substantial size (i.e. have to scroll down 200 contacts to find index of someone is very inconvenient).
Referring to your example, if you are unsure which john doe you are looking for, consider using the find command first, like you would for the deleting using index. We also think that a typo index is equally, if not more, likely to happen than a case typo in the contact name.
Additionally, regarding data loss resulting from a typo, it is stated in our planned enhancements that we plan to add an undo/redo feature to help with this.
Team chose [response.Rejected
]
Reason for disagreement: [replace this with your explanation]
Feature Flaw:
Deleting by name might be susceptible to accidental deletion of contacts with the same name but are differentiated only by their casing. ie.
John doe
andJohn Doe
As a result, you may want to delete
John Doe
but you accidentally wroteJohn doe
instead resulting in you deleting the data forJohn doe
instead ofJohn Doe
. Severity would be medium as this is likely to happen for duplicate names and the result would be catastrophic as theJohn doe
's data is completely lost without even confirmation.You may consider the original AB3 way of deleting by index.
Actual Output
Steps To Reproduce
John doe
andJohn Doe
delete n/John doe
when you wanted to deleteJohn Doe