juliusgambe / pe

0 stars 0 forks source link

[FeatureFlaw] No way to edit time #7

Open juliusgambe opened 9 months ago

juliusgambe commented 9 months ago

Feature Flaw:

If the person changes the time he is free for that particular time slot, I need to delete the time first and then add it back again. This is quite inconvenient and I may accidentally delete the wrong time slot every time I change.

Actual Output

Screenshot 2023-11-17 at 5.02.31 PM.png

soc-pe-bot commented 9 months ago

Team's Response

It is regarding not having the edit time function, similar to issue 5007 on having no edit person command.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

There is no Edit person command

In cases where users want to update particulars of a person, the user has to delete and add the person again. This could be tedious and cause inconvenience for users. There is no available screenshots for this issue since it seems that edit is treated as unknown command. It is absent in UG and DG main description and future implementations too


[original: nus-cs2103-AY2324S1/pe-interim#4310] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

A feature flaw is some functionality missing from a feature delivered in the current version in a way that the feature becomes less useful to the intended target user for normal usage. i.e., the feature is not 'complete'.

Not In scope: It is a valid issue but not something the team should be penalized for e.g., it was not related to features delivered in this version.

We had not delivered an edit function for contacts. Commands implemented are mentioned in the UG and since edit is not mentioned it is not part of the features. We did not deliver the edit function as we believed with the features we had provided, users could delete and add the contact and hence the edit function was not needed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Similar idea but that is for time and not for contacts. Thus, it is not a duplicate issue.


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** According to the definition of FeatureFlaws, ![Screenshot 2023-11-21 at 6.18.04 PM.png](https://raw.githubusercontent.com/juliusgambe/pe/main/files/e1f24134-0ac7-4ede-95e5-573ecb9096e6.png) The definition of a feature could be debatable. I believe that the features should be defined as what you have promised at the start of the UG - "Find free time for your group meetings." is a feature as stated at the introduction of your UG. Thus, the lack of editing free time would causes great inconvenience to the user and is a flawed design for leaving this feature out. ![Screenshot 2023-11-21 at 6.27.27 PM.png](https://raw.githubusercontent.com/juliusgambe/pe/main/files/4258187e-ca0e-471b-b596-c77c69c3205f.png) I forsee that editing free time would frequently happen as our free time changes frequently and dynamically. You would need to delete the free time first then add the new free time. This requires two commands which greatly hinders the user's ability to execute commands fast. As the target audience, fast-typist, is a project constraint, the lack of this command causes your product to not be well-designed for this target audience which falls under the definition of FeatureFlaw. Furthermore, as the frequency of editing free time might be high, this may result in us **accidentally** deleting the free time **frequently**. Furthermore, accidentally deleting a free time could be **catastrophic** as many other commands depend on it such as `findfreetime` which would result in incorrect results if you accidentally delete a free time and you were unaware of it. If you do realise the incorrect result, you would need to add the freetime and then redo the command again to get the proper result. Otherwise, you would have the wrong free time the whole time without realising it which is quite catastrophic as the whole project is no longer in sync. This is aggravated by the fact that your app is for organising projects and you would have **multiple group members.** This inaccuracy and inconvenience would even be **greater** as you do not know if all of the free times are correct anymore, rendering your app to no longer be effective in achieving the purpose of organising projects as a fast-typist. This causes great inconvenience as a result of the poor design of `finding a free time for group meetings` feature that is the central feature of your application. It should still be a medium for the inconvenience and catastrophic consequence of getting the wrong results as your app is designed to organise projects where this feature is central to your app.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I forsee that editing free time would frequently happen as our free time changes frequently and dynamically. You would need to delete the free time first then add the new free time. This requires two commands which greatly hinders the user's ability to execute commands fast. As the target audience, fast-typist, is a project constraint, the lack of this command causes your product to not be well-designed for this target audience which falls under the definition of FeatureFlaw. Furthermore, as the frequency of editing free time might be high, this may result in us **accidentally** deleting the free time **frequently**. Furthermore, accidentally deleting a free time could be **catastrophic** as many other commands depend on it such as `findfreetime` which would result in incorrect results if you accidentally delete a free time and you were unaware of it. If you do realise the incorrect result, you would need to add the freetime and then redo the command again to get the proper result. Otherwise, you would have the wrong free time the whole time without realising it which is quite catastrophic as the whole project is no longer in sync. This aggravated by the fact that your app is for organising projects and you would have **multiple group members.** This inaccuracy and inconvenience would even be **greater** as you do not know if all of the free times are correct anymore, rendering your app to no longer be effective in achieving the purpose of organising projects as a fast-typist. This causes great inconvenience as a result of the poor design of `finding a free time for group meetings` feature that is the central feature of your application. It should still be a medium for the inconvenience and catastrophic consequence of getting the wrong results as your app is designed to organise projects where this feature is central to your app.