search

juliushaertl / apporder

Nextcloud app to enable sorting inside the app menu
GNU Affero General Public License v3.0
45 stars 9 forks source link

Not working with NC25 #112

Closed jakobroehrl closed 2 years ago

jakobroehrl commented 2 years ago
juliushaertl commented 2 years ago

Due to server changes with the menu, the approach that this app uses to reorder does no longer work and there is currently no way to achieve that.

I've added a note to the readme https://github.com/juliushaertl/apporder/commit/9e3399190f7f3ddb7af314685ab0d8cf95c0d3b0 and currently consider the app unmaintained for that reason.

sunjam commented 2 years ago

Okay, I hope this can be addressed in the future and available within Nextcloud in some manner. It was an excellent app, so much love to it. Bye bye apporder. Cheers!

nursoda commented 2 years ago

From an admin perspective, AppOrder was a quite important app: To set default (first) and order, to not show certain apps in menu although installed, and all of that as admin/new user default with users being able to modify, or admin to enforce it. It's a real drawback in UX for the clouds I maintain.

Thanks Julius, for the work on that. I really hope (a) there is a technical way to achieve a similar feature set and (b) that someone volunteers to maintain it. (I don't, still struggle with my little app :) ).

sunjam commented 2 years ago

@nursoda Try Custom Menu app, which allows your to customize which apps are displayed in the top bar. Agreed that it is a bummer to lose the excellent AppOrder.

nursoda commented 2 years ago

Try Custom Menu app

Not yet available for NC25 though. Edit: On 2022-10-18, Custom Menu 3.0.0 was released, which is compatible with NC25 (and faster).

szaimen commented 1 year ago

@juliushaertl could this be used here? https://github.com/nextcloud/server/pull/34650

juliushaertl commented 1 year ago

Might but in the same hacky approach that the apporder app itself was built. The main problem with changing the order in the frontend is that it is tricky to get this right in the correct loading order and may always have side effects.

A proper way would be to ensure that the order can somehow already be handled on the backend side where the apps are sorted already by their predefined order https://github.com/nextcloud/server/blob/da01494a372c5b780ee76807325001afd1190b11/lib/private/NavigationManager.php#L136

One fairly straight forward attempt might be to emit an event in the server that an app like apporder can then listen to and adjust the navigation, I'm happy to hand over the app and release keys if anyone wants to start working on that, but cleaner would be to implement the sorting directly in server (https://github.com/nextcloud/server/issues/4917)

szaimen commented 1 year ago

All right, thanks for the input! Will post your comment in the issue in order to bring it forward.

simmstein commented 1 year ago

Custom Menu >= v3.1 implements an app sorter to (unfortunately) replace AppOrder.

I loved your app, thanks for all!

nursoda commented 1 year ago

Custom Menu >= v3.1 implements an app sorter

Couldn't AppOrder use the same mechanism?

simmstein commented 1 year ago

Yes and no. Yes because I did it in Custom menu so it's possible to do it in AppOrder. But if AppOrder must be compatible with Custom Menu, it's not possible. In custom menu, I replace the nextcloud AppMenu component by a custom one.

nursoda commented 1 year ago

Understood. Would it be possible to JUST use the reordering functionality (and probably some tweaks) in Custom Menu, so that reordering is available for original menu?

simmstein commented 1 year ago

Yeap!

gnilebein commented 1 year ago

Yeap!

It looks to me like the order can only be set globally? It would be nice if the goes for each user individually. Or am I missing something here?

Is there a possibility to show only the original menu? For me, both menus are always displayed.

nursoda commented 1 year ago

This is the wrong place for Custom Menu (side_menu) Support. @simmstein Please send an URL where to continue – RFE issue? NC forum?

simmstein commented 1 year ago

Main support is on https://gitnet.fr/deblan/side_menu

jcb-tn commented 1 year ago

It's horrible, how much apps no longer working with NC25. I am very dissatisfied with the teamwork of NC. Hope someone with dev competence can get this app to go again :-) .

crazybadger commented 1 year ago

Very sad that this is no longer supported, and wholly agree this should be core functionality. The ability to switch certain apps on/off for some users/groups is pretty fundamental, and reordering them a nice to have.

bcutter commented 1 year ago

Head over to "Custom Menu" which can do the same (and much more).

Loved AppOrder too. Technology comes, software goes, circle of life.

battosai30 commented 1 year ago

My point : I prefer the standard menu, mainly because it's a one less click to do. Custom menu does not allow to keep it.

So I hope this app will find a new energy to continue to exist ;)

gnilebein commented 1 year ago

My point : I prefer the standard menu, mainly because it's a one less click to do. Custom menu does not allow to keep it.

So I hope this app will find a new energy to continue to exist ;)

It is possible:

https://gitnet.fr/deblan/side_menu/issues/161#issuecomment-1320

battosai30 commented 1 year ago

My point : I prefer the standard menu, mainly because it's a one less click to do. Custom menu does not allow to keep it. So I hope this app will find a new energy to continue to exist ;)

It is possible:

https://gitnet.fr/deblan/side_menu/issues/161#issuecomment-1320

Cool ! Thanks for the (not so obvious) tip ^^

nursoda commented 1 year ago

Yes, one can achieve similar results, but it requires manual fiddling each time you change your app setup. In my opinion, it would be much easier if any volunteer created a revamped apporder app that uses the mechanism side_menu uses. These two apps then would be mutually incompatible though. Or side_menu reduces complexity by moving the reorder stuff in a separate app that is compatible to with and without side_menu. wishful thinking

simmstein commented 1 year ago

Or side_menu reduces complexity by moving the reorder stuff in a separate app that is compatible to with and without side_menu. wishful thinking

This is not in the roadmap!

crazybadger commented 1 year ago

Thanks for the heads up on Custom Menu. It's a little more setup than App Order, and still on a user-by-user basis. If there were some options to apply to groups it would be much more useful

bcutter commented 1 year ago

I think you can force a default/global setting for all users (the one you set as admin). But that's no Custom Menu support corner here :-)

pReya commented 1 year ago

Due to server changes with the menu, the approach that this app uses to reorder does no longer work and there is currently no way to achieve that.

I've added a note to the readme 9e33991 and currently consider the app unmaintained for that reason.

@juliushaertl Could you give some more details about why this won't work anymore? What changed?

juliushaertl commented 1 year ago

The menu is no longer rendered during initial page rendering on the backend side but dynamically with Javascript. Apporder was using quite a hack approach to change the DOM element order with javascript which will no longer work if the new vue code that renders the menu updates the rendered DOM structure.

For reference https://github.com/nextcloud/server/pull/33728 is the server PR implementing the new menu code base.