Doesn't work with Direct Menu app

juliushaertl / apporder

Nextcloud app to enable sorting inside the app menu

GNU Affero General Public License v3.0

45 stars 9 forks source link

Doesn't work with Direct Menu app #25

Closed spoorun closed 7 years ago

spoorun commented 7 years ago

The order doesn't stick when using the Direct Menu app (which shows icons along the top rather than in the drop-down corner menu - thus saving time when working). https://apps.owncloud.com/content/show.php/Direct+Menu?content=169148

juliushaertl commented 7 years ago

Thanks for your report, can you please give some more information on what software you are using?

Nextcloud/ownCloud
apporder version
direct_menu version Are there any errors in the log files/browser console?

spoorun commented 7 years ago

nextcloud 10.0.1 apporder 0.3.3 direct_menu 0.9.2

This error in the log files (attached), repeated several times, so have just included on instance. logfile-extract.1.txt

juliushaertl commented 7 years ago

@olantrust Sorry for the long delay.

I'm using the exact same version setup here and everything works fine. The error message looks like the javascript code isn't transfering the order to the save endpoint.

Can you describe a bit more what is happening? Can you drag and drop icons, will the order stick? When does the error in the log files occur? Is apporder working in your setup when you have direct_menu disabled?

zerojay commented 7 years ago

I'm not the OP but I'm using App Order 0.3.3 with NextCloud 10.0.1 and I am not using direct_menu at all and I seem to have the exact same log errors as posted earlier in this thread.

I am able to drag and drop icons and the order sticks so long as I don't change what page I'm on. Then it reverts back to what it was previously. This appears to have started happening when I upgraded from v.0.3.2 to v0.3.3.

juliushaertl commented 7 years ago

@zerojay Thanks for the infos.

@zerojay @olantrust Can anyone of you please also check the browser error console as well as the network console (just hit F12 in your browser window)

The network console should show a request to personal.php after you've dragged the icons around. Can you send me a screenshot of this request on your instance or right-click and copy as HAR? 2016-12-04-103603_1916x968_scrot

zerojay commented 7 years ago

Here's the error log: https://zerojay.com/nextcloud/index.php/s/3GBAzCM4HtlpOjQ

juliushaertl commented 7 years ago

@zerojay Ok thanks, I'll try to investigate and fix that later today.

juliushaertl commented 7 years ago

@zerojay @olantrust I'm still not able to reproduce this. It looks like the Nextcloud core code https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Http/Dispatcher.php#L128-L158 is not setting the $order parameter correctly.

Could you also fill out the issue template about server configuration/versions and paste it here as well? https://github.com/nextcloud/server/blob/master/issue_template.md

juliushaertl commented 7 years ago

@zerojay @olantrust Can you test if the reordering works with the changes in #26?

zerojay commented 7 years ago

Sorry it took so long to respond. I previously attempted it and found it didn't work, but just took a second look and saw that I put in a capital letter in somewhere I shouldn't have and when I fixed it, it worked, so yes, I can validate that #26 does fix this bug. Thank you.

juliushaertl commented 7 years ago

@zerojay No problem. Good to know that it works now. :wink: