Implementation of hide

[bakkegaard]

I would like some feedback on this code before I polish it up.

• What naming convention should I use?
• Should the getOrder and getHidden be made into just one AJAX call, so we don't need to make two AJAX call every time a page loads.
• Should the code in controller be split up in more files?
• Should I force push when I update the pull request or just add more commits?

To do

• [x] Test if it works when there are a lot of apps and the dropdown is activated.
• [x] It shouldn't be possible for an app to be the default app if it is hidden.
• [x] Add tests
• [x] Fix checkbox design (CSS isn't what I do best, so help would be very appreciated)
• [ ] Make a thorough test of it all

[juliushaertl]

@bakkegaard Thanks, looks good so far except for some small comments :+1:

[bakkegaard]

Now it should be pretty much done, the only thing missing is the design. I have thought about it and think there are three ways we can go

1. Copy the activity settings from above where first column is the checkbox, second is the icon and third is the text
   
2. Remove the checkbox and do so when you click on the icons the color flips together with the hidden/not hidden
3. A combination where we use design 1. but flips the color anyway.

Let me know what you think :)

[juliushaertl]

@bakkegaard Sorry, totally missed that comment. :wink:

I made a commit to fix the styling here: https://github.com/juliushaertl/apporder/commit/263ff18d07e8bf7c287af143d718bae258cacd13

Feel free to cherry-pick that commit into your pull request.

[juliushaertl]

This is how it looks like:

[bakkegaard]

No problem. Damn it looks good. Nice work. I will try to make a thorough test within the next couple of days to make sure everything works as expected. Feel free to do it yourself and merge, unless you have other comments on the code?

[juliushaertl]

@bakkegaard I found some bugs when testing this :wink:

• No apps are shown after installing the app on a clean installation
• Change order as admin -> visit personal settings -> apps are not showing in the admins order there

Otherwise this works quite well. Great work so far. We can merge once these two errors are fixed ;)

[bakkegaard]

@juliushaertl should be fixed now :)

[RainerEmrich]

@bakkegaard , @juliushaertl I tested this version with nextcloud 12.0.1RC4. Looks really good and works AFAIS. It would be really nice if there will be a new release in the next days.

[juliushaertl]

@bakkegaard Thanks for this PR. Works really nice. Let's merge this so we can get a new release out.