juliushaertl / direct_menu

Nextcloud/OwnCloud app to provide easy access to all apps in the header
GNU Affero General Public License v3.0
17 stars 8 forks source link

Menu overlapping #32

Closed Guillaume99 closed 8 years ago

Guillaume99 commented 8 years ago

When resizing the browser window, the menu is ovelapping with the search icone before being removed. See attached picture (Firefox 48, Nextcloud 9.0.53, Direct Menu 0.9)...

menu ok menu overlap menu removed

juliushaertl commented 8 years ago

This is something we can't fix that easy, as the width of the menu depends on the number of apps you have installed. But yes, this is something that sould be fixed.

juliushaertl commented 8 years ago

@Guillaume99 This should be fixed now on master. Would be great if you could do some testing.

Guillaume99 commented 8 years ago

hello Julius,

I did some testing with NC10 and the master branch, but it is still overlapping … :-(

Le 3 sept. 2016 à 10:23, Julius Härtl notifications@github.com a écrit :

@Guillaume99 https://github.com/Guillaume99 This should be fixed now on master. Would be great if you could do some testing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juliushaertl/direct_menu/issues/32#issuecomment-244532073, or mute the thread https://github.com/notifications/unsubscribe-auth/ATPKnZuDqjEjI3mTHU7sHRR5mp1XnJ2Qks5qmSBfgaJpZM4JpGNM.

juliushaertl commented 8 years ago

Have you installed the master release by downloading a zip from Github? Can you make sure that there are only the files present that are now on the current master?

The best would be to remove the entire direct_menu folder before extracting the "master"-zip. Otherwise there are a couple of files from the old version, that don't get removed.

If it still doesn't work with a clean direct_menu folder, could you check if https://yourclouddomain.com/index.php/apps/direct_menu/styles is loaded (use your browser debugging tools by hitting F12)

On 04.09.2016 12:42, Guillaume99 wrote:

hello Julius,

I did some testing with NC10 and the master branch, but it is still overlapping … :-(

Le 3 sept. 2016 à 10:23, Julius Härtl notifications@github.com a écrit :

@Guillaume99 https://github.com/Guillaume99 This should be fixed now on master. Would be great if you could do some testing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juliushaertl/direct_menu/issues/32#issuecomment-244532073, or mute the thread https://github.com/notifications/unsubscribe-auth/ATPKnZuDqjEjI3mTHU7sHRR5mp1XnJ2Qks5qmSBfgaJpZM4JpGNM.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/juliushaertl/direct_menu/issues/32#issuecomment-244595780, or mute the thread https://github.com/notifications/unsubscribe-auth/ADPxZUqIejvy-NjkcQHACmAdklE_fWOCks5qmqCngaJpZM4JpGNM.

Guillaume99 commented 8 years ago

hello Julius,

yes, that exactly how I installed your app… but I stil have the problem, so I did a little investigation and found where it came from.

For any reason, the « Tasks » app is not counted, you can add or remove it, the min-width value will not change !

This is probably not related to your code, and your application is quite good now !

Guillaume

update : the ownNote is doing the same...

Le 4 sept. 2016 à 14:56, Julius Härtl notifications@github.com a écrit :

Have you installed the master release by downloading a zip from Github? Can you make sure that there are only the files present that are now on the current master?

The best would be to remove the entire direct_menu folder before extracting the "master"-zip. Otherwise there are a couple of files from the old version, that don't get removed.

If it still doesn't work with a clean direct_menu folder, could you check if https://yourclouddomain.com/index.php/apps/direct_menu/styles is loaded (use your browser debugging tools by hitting F12)

On 04.09.2016 12:42, Guillaume99 wrote:

hello Julius,

I did some testing with NC10 and the master branch, but it is still overlapping … :-(

Le 3 sept. 2016 à 10:23, Julius Härtl notifications@github.com a écrit :

@Guillaume99 https://github.com/Guillaume99 This should be fixed now on master. Would be great if you could do some testing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juliushaertl/direct_menu/issues/32#issuecomment-244532073, or mute the thread https://github.com/notifications/unsubscribe-auth/ATPKnZuDqjEjI3mTHU7sHRR5mp1XnJ2Qks5qmSBfgaJpZM4JpGNM.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/juliushaertl/direct_menu/issues/32#issuecomment-244595780, or mute the thread https://github.com/notifications/unsubscribe-auth/ADPxZUqIejvy-NjkcQHACmAdklE_fWOCks5qmqCngaJpZM4JpGNM.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juliushaertl/direct_menu/issues/32#issuecomment-244599168, or mute the thread https://github.com/notifications/unsubscribe-auth/ATPKnY1PHMmOs81EKDrdwwP8jGqtQN9Rks5qmrHXgaJpZM4JpGNM.

juliushaertl commented 8 years ago

Ah, ok i'll have a look what might go wrong therr.

powerpaul17 commented 7 years ago

I just noticed that if I use the search icon in an app which supports it, the opening input field still overlaps the menu icons.

juliushaertl commented 7 years ago

@powerpaul17The overlapping search box has been fixed now in #58.Thanks for the hint.

powerpaul17 commented 7 years ago

Thank you, you're welcome.