search

juliushaertl / direct_menu

Nextcloud/OwnCloud app to provide easy access to all apps in the header
GNU Affero General Public License v3.0
17 stars 8 forks source link

adjust whitespace and top border radius to match other dropdowns #48

Closed jancborchardt closed 7 years ago

jancborchardt commented 7 years ago

Before: capture du 2016-12-17 04-37-33

After: capture du 2016-12-17 04-35-34

Please review @juliushaertl @eppfel @skjnldsv

Btw we should also adjust the shadows then. Probably use the shadow from here on the other dropdowns because it’s much nicer and softer. @juliushaertl do you want to prepare a PR for core so we have it in one place? :)

eppfel commented 7 years ago

I think Julius design is visually more coherent, because it is an element hovering over the page, so it does not have to align to the content under it. With the dropdown on the edge your eye fights to understand wether the element sits under the header or above, because there is a shadow, but it is also placed right below the edge. Maybe We could even go a little bit higher to clearly show it sits above the header.

jancborchardt commented 7 years ago

So one thing we agree on though is that it should be the same look, right @eppfel?

I think the design of the current apps and users menu is better because it has less lines and feels more integrated with the header. The overlaying popover looks like it basically is unaware of its surroundings and feels unpolished, if you know what I mean?

juliushaertl commented 7 years ago

Btw we should also adjust the shadows then. Probably use the shadow from here on the other dropdowns because it’s much nicer and softer. @juliushaertl do you want to prepare a PR for core so we have it in one place? :)

Will do so. ;)

I'm with @eppfel on the positioning of the popovers, they should clearly stay above the rest of the content.

eppfel commented 7 years ago

So one thing we agree on though is that it should be the same look, right @eppfel?

Yes

I think the design of the current apps and users menu is better because it has less lines and feels more integrated with the header.

Sry, but I don't understand you here. Which lines? 😁

The overlaying popover looks like it basically is unaware of its surroundings and feels unpolished, if you know what I mean?

That's why it has an arrow/tip, right? And besides that it can be unaware, because it's a pop-over 😆

But yeah, the shadows look smoother with Julius and before we change it on the server side, it should look the same.