juliushaertl / nextcloud-docker-dev

Nextcloud development environment using docker-compose
GNU Affero General Public License v3.0
126 stars 67 forks source link

Devcontainer not working anymore for some Nextcloud apps on Github #316

Closed ronau closed 4 days ago

ronau commented 3 months ago

It seems like the Devcontainer is not working anymore for at least the following Nextcloud app repositories:

https://github.com/nextcloud/deck https://github.com/nextcloud/tables

Both repos rely on nextcloud-dev-php80 for their Devcontainer setup.

I'm not sure if this is the right place to report this error. Maybe I should do it over at the app repos? I suppose something's wrong with the devcontainer config in those repositories. However, I guess it's probably easier for you guys to have a look and detect the issue.

Anyway, I always get the following error message:

🚨 Could not find a valid Nextcloud source in /var/www/html
Double check your REPO_PATH_SERVER and STABLE_ROOT_PATH environment variables in .env

I get the error message in both a VS Code Devcontainer on macOS as well as here in Github Codespaces.

juliushaertl commented 3 months ago

Thanks for reporting. Likks like this was caused by https://github.com/juliushaertl/nextcloud-docker-dev/commit/42925f47ecb534b2b32403193b8c4afc77558a4a#diff-bb5305da9907f05193b9d756f5afb1e7ed55657d8cbb2ea96ce3c6b3beb08d56R359 I'll see if I can come up with a fix soonish.

ronau commented 1 week ago

Hi, I'd really love to see some progress on this one here. Or maybe - if it's easier - I would be happy already with some hints how to work around this issue.

So, what I was actually trying to do: Running the current version of https://github.com/nextcloud/deck in a development environment (e.g. Devcontainer, as suggested by the deck project) in order to tinker around with it (eventually trying to fix another bug or find it's root cause at least).

juliushaertl commented 4 days ago

I just pushed a fix with cf972bda5bd94b8abbfbea92579663a76123e40d, new images have been built and the devcontainer on deck works again. Thanks for reporting.