search

juliuskoval / NLog.Targets.OpenTelemetryProtocol

1 stars 4 forks source link

injected options #14

Closed juliuskoval closed 2 months ago

juliuskoval commented 3 months ago

Addresses https://github.com/juliuskoval/NLog.Targets.OpenTelemetryProtocol/issues/13.

@snakefoot would you mind taking a look at this please?

@TheXenocide is this what you had in mind?

TheXenocide commented 2 months ago

Yes indeed, looks good to me. I'm not sure about the applicability of IOptionsSnapshot (vs IOptionsMonitor) since I haven't read through enough of the code to know if it will pick up updates in the config at runtime, but that functionality isn't so important to me compared to being able to leverage the existing configuration pattern which this appears to satisfy from what I can see.