Invalid fields are added to Teacher's details

[juliussneezer04]

Invalid fields like em/ and a/ are allowed to be added and show up in the teacher's involvement

Expected: Throw error for entering invalid fields

Actual: Allowed

[nus-pe-bot]

Team's Response

They are valid characters, so our team decided to give the users flexibility since a teacher's involvement could very well involve "em/" characters. The "em/" and "a/" prefix are also not used in teachers, so there's no confusion. Since these are not prefixes for the teacher fields, these should be allowed to be included in the involvement field.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: # Reason:

• While giving flexibility is useful, at the very least a warning could be shown to notify teachers so they don't accidentally add unnecessary info like em/ or a/, that is clearly from addStudent, and it is not unlikely that teachers could make the same mistake.
• A better solution however, would be to discard erroneous parameters and throw errors rather than allow them.
• If both are intended, this could be changed to a FeatureFlaw

---