juliussneezer04 / pe

0 stars 0 forks source link

findTeacher accepts invalid fields #17

Open juliussneezer04 opened 3 years ago

juliussneezer04 commented 3 years ago

Expected: findTeacher throws error for invalid field 'i/' OR show teachers with involvement 'Math' (See example)

Actual: findTeacher does not display any teachers and shows no errors

image.png

nus-pe-bot commented 3 years ago

Team's Response

This command is not supposed to show teachers with involvement 'Math' as findTeacher is only supposed to search by name.

This is the intended behaviour, this just means that there are no teachers with the name i/Math. It's not in scope for the findTeacher command to make sure the user's input makes sense since any search query is a valid search query.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: # Reason: