julkascript / cardflow

The open-source Trading Card Game market
MIT License
10 stars 4 forks source link

Introduce Internationalization #115

Closed julkascript closed 5 days ago

julkascript commented 3 weeks ago

Requirements:

% UI/UX design in progress

Additional tips:

@RyotaMitaraiWeb I want to leave the architecture/setup more flexible, so it's more fun for you. Let me know if you want to discuss this.

RyotaMitaraiWeb commented 2 weeks ago

this is going to be my first time dealing with internalization, so gonna leave these thoughts here for transparency:

julkascript commented 2 weeks ago
RyotaMitaraiWeb commented 2 weeks ago

integration has been going well so far (managed to get it working + saving the language in localStorage comes right out of the box), I currently need translations for all TCG-related terms, as I am not well-versed with the Bulgarian TCG community and wouldn't know what would be an appropriate translation for them. Some examples:

(the list isn't exhaustive, feel free to include anything that may not be obvious to an outsider)

julkascript commented 2 weeks ago

integration has been going well so far (managed to get it working + saving the language in localStorage comes right out of the box), I currently need translations for all TCG-related terms, as I am not well-versed with the Bulgarian TCG community and wouldn't know what would be an appropriate translation for them. Some examples:

  • "Trading card game"
  • "listing"
  • the different card conditions, like "Poor", "Played" (including them here, since they seem to be actual terms within the TCG communities)

(the list isn't exhaustive, feel free to include anything that may not be obvious to an outsider)

RyotaMitaraiWeb commented 1 week ago

I am pretty much done with the translations (as far as I am concerned, at least) and the only thing left is to implement something with which the language can be changed. I decided to brainstorm some ideas for a potential design (if you had something else in mind, feel free to share, I didn't spend a lot of time on the wireframes, so nothing of value is going to waste):

https://www.figma.com/design/DTnEVV4abr1f2FIFBckWlt/Change-language?node-id=0-1&t=IQk7qcMXUjsqPHq0-1

I have provided some comments with more details in the wireframe.

My personal preference would be variant 1-1 (full text + outline), followed by variant 1-4 (minimalist + outline), and variant 2 for the mobile design, but I am open to anything.

julkascript commented 6 days ago

Thanks for the design input. I would personally prefer the language select to be in the side menu because it’s not going to be used much (probably almost never), because we want to immediately show BG content to BG users and EN to all others. Usually I would put buttons/items in the navigation that are used more often (for a platform web app like ours).

But if I had to pick from what you did, I’d go for the super minimalistic variant .3 or .4

If you don’t feel like playing with this anymore, I am also fine with sticking it in the navbar for now with any of the variants.

RyotaMitaraiWeb commented 6 days ago

I will need some clarification, because our desktop layout currently doesn't have a side menu, as far as I am understanding the suggestion.

An alternative is to have a footer as part of the app layout and put the language select there (alongside with other stuff we may want to add), I could spin up a wireframe if desired

julkascript commented 5 days ago

Nevermind. For now, let’s proceed with any of the variants 3, 4 or 1-1. If we need, we can change it up in a later stage.