search

julmud / phpDVDProfiler

Adoption of the defunct phpDVDProfiler
MIT License
1 stars 4 forks source link

Add a separate media type for 4k/UHD #2

Closed gjnoonan closed 4 years ago

gjnoonan commented 4 years ago

As requested on the forums, as well as scratching my own itch. 4K releases are now treated as separate media-type when imported. This allows the user to not only; see visually which releases are 4k,if they have format icons enabled within their config, but also filter to 4K releases.

Works nicely on a test DB I put together.

Screenshot 2020-01-05 at 06 50 19

Screenshot 2020-01-05 at 06 51 00

Screenshot 2020-01-05 at 06 51 29

Still left to do is the movie picker/chooser, but this won't be too much work for a later commit.

More information in the commit messages, I would suggest not squashing commits when you merge.

julmud commented 4 years ago

Wow, thanks a lot for this Pull Request! I'll have a look at it and merge it as soon as I can find the time to do it, but it probably won't be today nor tomorrow, alas.

gjnoonan commented 4 years ago

No worries! I have a few more lined up to send in once I finish testing them, and splitting the hunks--but none are dependent on this being in master :-)

gjnoonan commented 4 years ago

I still want to do a few tests later today or tomorrow evening before merging, but it looks good. Thanks a lot!

Thanks @julmud I will re-roll with the above changes today.

gjnoonan commented 4 years ago

@julmud I have pushed up V2 of the changes incorporating a suggested change, and introducing a new commit 02b7a5e3e98d4d3eb84ad7ec2b65e73ef0ff01b2 which will add a .gitignore which has your suggested change also.