julmud / phpDVDProfiler

Adoption of the defunct phpDVDProfiler
MIT License
1 stars 4 forks source link

PHP 8 compatibility fixes #30

Closed sebk-666 closed 1 year ago

sebk-666 commented 1 year ago

Hi, I fixed the array indexing from $array{i}-style to $array[i] in all the places I could find. Also, the sql_freeresult() function in mysqli.php caused the script to break when called on an already freed query_id (as it happens in info.php). Not sure why the Id:-lines in userprefs.php and statistics.php get stripped when pushing - they are still present in my local code.

julmud commented 1 year ago

Thanks a lot. I'll have a look at it as soon as I can find some time (which might not be before the end of the year...)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information