julmud / phpDVDProfiler

Adoption of the defunct phpDVDProfiler
MIT License
1 stars 4 forks source link

Searches display first profile in right frame regardless of $InitialRightFrame #42

Open MotyerJM opened 1 year ago

MotyerJM commented 1 year ago

Hello, Julien,

This is NOT a issue, but thought I would mention it.

I do not know if the below is a bug in phpDVDProfiler, or if it has just been an inconsistency over the years, or if it was always supposed to be this way. Whichever is the case, it has probably been this way for more than a decade.

In localsiteconfig, we are able to set $InitialRightFrame to be whatever we wish: Front Gallery, Back Gallery, Statistics or default (which is the first profile). I use Front Gallery for all my collections, and this works as it is supposed to when a user first accesses my collections, and when they press the Clear button near the top-left.

However, if a user does a search, the Right Frame always displays the first profile, even though I have $InitialRightFrame='Front Gallery' set.

I realize that in $InitialRightFrame, the key word is Initial, as in when a user initially accesses a collection.

You would not want phpDVDProfiler to display the right frame in searches to always be whatever the administrator chooses with $InitialRightFrame, because some administrators may like it the way it is, with the right frame always displaying the first profile when searching.

But depending on how difficult it would be to implement, possibly, when you are reviewing the code for other fixes/enhancement that you're working on, you could think about maybe adding another setting to localsiteconfig in a future release, such as $SearchRightFrame (or whatever you wish to call it), to allow us administrators to choose what to display in the right frame when searches are done. Just a thought.

Thanks again for your dedication to it.