julz / importas

linter to enforce consistent import aliases
Apache License 2.0
14 stars 12 forks source link

Using importas within golangci-lint w/ both no-unaliased and no-extra-aliases fails #15

Open johndlong opened 1 year ago

johndlong commented 1 year ago

Looking to leverage both no-unaliased and no-extra-aliased flags in golangci-lint, and end up getting results where un-aliased imports start giving problematic results. Ideally we'd have the restrictions provided by both the flags (consistent, always-defined aliases; rejecting any new aliases that aren't described)

linters-settings:
  importas:
    no-unaliased: true
    no-extra-aliases: true
    alias:
...

Which results in a number of issues, where even standard libraries act as if they have an alias but not in the config:

import "time" has alias "" which is not part of config (importas)
        "time"
nightlyone commented 1 year ago

To add a bit more detail what the behavior should be in that case:

That makes it easier to copy code snippets around between files with those aliases.