github-actions[bot]
commented
5 months ago 
> [!CAUTION]Breaking Flaw identified in code!
https://github.com/julz0815/test-action/blob/ced1fb232c158fccd1e1b366671c0a6968ee66fc/src/main/java/com/veracode/verademo/commands/IgnoreCommand.java#L40-L52
> [!CAUTION]CWE: 89 - Severity: 4
This database query contains a SQL injection flaw. The call to java.sql.Statement.execute() constructs a dynamic SQL query using a variable derived from untrusted input. An attacker could exploit this flaw to execute arbitrary SQL queries against the database. The first argument to execute() contains tainted data from the variable sqlQuery. The tainted data originated from earlier calls to AnnotationVirtualController.vc_annotation_entry, java.sql.PreparedStatement.executeQuery, and java.sql.Statement.executeQuery. Avoid dynamically constructing SQL queries. Instead, use parameterized prepared statements to prevent the database from interpreting the contents of bind variables as part of the query. Always validate untrusted input to ensure that it conforms to the expected format, using centralized data validation routines when possible. References: CWE OWASP
```diff
--- src/main/java/com/veracode/verademo/commands/ListenCommand.java
+++ src/main/java/com/veracode/verademo/commands/ListenCommand.java
@@ -34,10 +34,12 @@
action.setString(2, username);
action.execute();
- sqlQuery = "SELECT blab_name FROM users WHERE username = '" + blabberUsername + "'";
- Statement sqlStatement = connect.createStatement();
- sqlQuery = "SELECT blab_name FROM users WHERE username = ?"; logger.info(sqlQuery);
- ResultSet result = sqlStatement.executeQuery(sqlQuery);
- PreparedStatement sqlStatement = connect.prepareStatement(sqlQuery);
- sqlStatement.setString(1, blabberUsername);
-
ResultSet result = sqlStatement.executeQuery(); result.next();
/* START BAD CODE -----*/
```
> [!CAUTION]Breaking Flaw identified in code!
https://github.com/julz0815/test-action/blob/ced1fb232c158fccd1e1b366671c0a6968ee66fc/src/main/java/com/veracode/verademo/commands/IgnoreCommand.java#L40-L52
> [!CAUTION]CWE: 89 - Severity: 4
This database query contains a SQL injection flaw. The call to java.sql.Statement.execute() constructs a dynamic SQL query using a variable derived from untrusted input. An attacker could exploit this flaw to execute arbitrary SQL queries against the database. The first argument to execute() contains tainted data from the variable sqlQuery. The tainted data originated from an earlier call to AnnotationVirtualController.vc_annotation_entry. Avoid dynamically constructing SQL queries. Instead, use parameterized prepared statements to prevent the database from interpreting the contents of bind variables as part of the query. Always validate untrusted input to ensure that it conforms to the expected format, using centralized data validation routines when possible. References: CWE OWASP
```diff
--- src/main/java/com/veracode/verademo/commands/RemoveAccountCommand.java +++ src/main/java/com/veracode/verademo/commands/RemoveAccountCommand.java @@ -8,6 +8,7 @@
import org.apache.log4j.LogManager; import org.apache.log4j.Logger; +import java.util.*;
public class RemoveAccountCommand implements BlabberCommand { private static final Logger logger = LogManager.getLogger("VeraDemo:RemoveAccountCommand"); @@ -35,16 +36,23 @@ action.execute();
Statement sqlStatement = connect.createStatement(); logger.info(sqlQuery); ResultSet result = sqlStatement.executeQuery(sqlQuery); result.next();
sqlStatement.execute();
```