jumaallan / dev-fest-2019

An App which shows how to use Dynamic Modules, MVVM, Room, DI, App Bundles and Internal App Sharing (PlayStore), in Kotlin)
MIT License
37 stars 21 forks source link

Use base module version code and name #9

Closed odaridavid closed 5 years ago

odaridavid commented 5 years ago

Gradle uses app version information that the base module provides, helps manage version across app for dynamic features. They will use versions from app module in this case

jumaallan commented 5 years ago

Interesting! I always thought each module manages its own version.

@Davidodari Any resources on the same?

odaridavid commented 5 years ago

Interesting! I always thought each module manages its own version.

@Davidodari Any resources on the same?

From the docs under The base module build configuration:App Versioning

https://developer.android.com/studio/projects/dynamic-delivery/configure-base

The version code from the base module is what will be used for all generated apks from the bundle so you can just omit these properties from your dynamic module's build.gradle file.

jumaallan commented 5 years ago

Thanks