Open robert914 opened 2 years ago
The shfmt pre-commit hook fails if the file path contains spaces. The issue is that these lines in: https://github.com/jumanjihouse/pre-commit-hooks/blob/master/pre_commit_hooks/shfmt
shfmt
readonly cmd="shfmt -w $*" echo "[RUN] ${cmd}" ${cmd}
should probably instead be something like:
readonly cmd=(shfmt "-w" "$@") echo "[RUN] ${cmd[@]}" "${cmd[@]}"
To properly handle spaces in paths. Thanks!
The
shfmt
pre-commit hook fails if the file path contains spaces. The issue is that these lines in: https://github.com/jumanjihouse/pre-commit-hooks/blob/master/pre_commit_hooks/shfmtshould probably instead be something like:
To properly handle spaces in paths. Thanks!