search

jumanjihouse / pre-commit-hooks

git pre-commit hooks that work with http://pre-commit.com/
MIT License
114 stars 52 forks source link

(INVALID) Shell check download url has changed upstream. #65

Closed Aricg closed 4 years ago

Aricg commented 4 years ago

INVALID you don't install shell check for us, we have it installed on our systems via packer you can close this out as invalid.

Currently bumping our version of jumanjihouse/pre-commit-hooks to 2.1.4 to test if it's fixed. EDIT: same issue found with with 2.1.4

  - repo: https://github.com/jumanjihouse/pre-commit-hooks
    sha: 2.1.4
    hooks:
      - id: shellcheck
        exclude: >
            (?x)^(
                jjb/global-jjb/.*|
                jenkins-config/.*
            )$

Seeing this new error in our build logs. our .pre-commit-config.yaml

   - repo: https://github.com/jumanjihouse/pre-commit-hooks
     sha: 2.0.2
     hooks:
       - id: shellcheck
         exclude: >
             (?x)^(
                 jjb/global-jjb/.*|
                 jenkins-config/.*
             )$

our tox.ini

[testenv:pre-commit]
basepython = python3
deps = pre-commit
commands =
    pre-commit install --hook-type commit-msg
    pre-commit run --all-files --show-diff-on-failure
    pre-commit run gitlint --hook-stage commit-msg --commit-msg-filename .git/COMMIT_EDITMSG


12:05:13 Test shell scripts with shellcheck.......................................Failed
12:05:13 - hook id: shellcheck
12:05:13 - exit code: 1
12:05:13 
12:05:13 You are downloading ShellCheck from the wrong URL!
12:05:13 
12:05:13 Please update to the correct URL:
12:05:13 https://github.com/koalaman/shellcheck/releases/download/v0.7.1/shellcheck-v0.7.1.linux.x86_64.tar.xz
12:05:13 
12:05:13 For more information, see:
12:05:13 https://github.com/koalaman/shellcheck/issues/1871
12:05:13 You are downloading ShellCheck from the wrong URL! https://git.opendaylight.org/gerrit/c/releng/builder/+/91779 

12:05:13 
12:05:13 Please update to the correct URL:
12:05:13 https://github.com/koalaman/shellcheck/releases/download/v0.7.1/shellcheck-v0.7.1.linux.x86_64.tar.xz
12:05:13 
12:05:13 For more information, see:
12:05:13 https://github.com/koalaman/shellcheck/issues/1871
12:05:13