fix circleci errors via update to rubocop dependencies

jumanjihouse / pre-commit-hooks

git pre-commit hooks that work with http://pre-commit.com/

MIT License

114 stars 52 forks source link

fix circleci errors via update to rubocop dependencies #84

Closed MightyNerdEric closed 3 years ago

MightyNerdEric commented 3 years ago

Sets reek and rubocop to latest versions. "required_ruby_version" and "TargetRubyVersion" have been set based on info here: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion Resolves #83

MightyNerdEric commented 3 years ago

@jumanjiman Please take a look at this fix for errors currently occurring in other PRs. We here at the Linux Foundation would love to see the shellcheck hook get the fix it needs for pre-commit 2.10.0 (currently both #80 and #81 are open for the same fix, though 81 looks a bit more complete), and since I figure you may not want to merge anything that has failing CircleCI checks, I've gone ahead and made the necessary updates to get the rubocop tests back to a passing configuration.

jumanjiman commented 3 years ago

@MightyNerdEric TYVM!

askb commented 3 years ago

@jumanjiman Can we get a new release/tag out please, we are still using the additional_dependencies workaround with 2.1.4. TIA

jumanjiman commented 3 years ago

@jumanjiman Can we get a new release/tag out please, we are still using the additional_dependencies workaround with 2.1.4. TIA

oops, done!

ty for the reminder!

2.1.5 is up