search

jumaris / indyproject

Automatically exported from code.google.com/p/indyproject
0 stars 0 forks source link

SASL is broken in TIdIMAP4 #247

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When the TIdIMAP4.AuthType property is set to iatSASL, the AUTHENTICATE command 
is not formatted correctly so IMAP servers reject it.  This is because 
TIdSASLCollection.LoginSASL() uses the TIdTCPConnection.SendCmd() method to 
send commands and read responses, but TIdIMAP4 does not override 
TIdTCPConnection.SendCmd() or TIdTCPConnection.Get(Internal)Response().  It 
reintroduces its own custom implementations instead that TIdSASLCollection does 
not call at all.  So TIdIMAP4 needs to be changed to either override the 
TIdTCPConnection methods instead of reintroducing its own methods, or else to 
send the AUTHENTICATE command directly and not use the 
TIdSASLCollection.LoginSASL() method anymore.

Original issue reported on code.google.com by gambit47 on 8 Feb 2013 at 3:52

GoogleCodeExporter commented 9 years ago

Original comment by gambit47 on 9 Feb 2013 at 2:08

GoogleCodeExporter commented 9 years ago 
Implemented in rev 4930 and patched in rev 4961.

Original comment by gambit47 on 18 Jul 2013 at 4:27