jumbojett / OpenID-Connect-PHP

Minimalist OpenID Connect client
https://github.com/jumbojett/OpenID-Connect-PHP
Apache License 2.0
614 stars 367 forks source link

implicit never used ! (auth code flow hard coded !) #198

Open rochatjl opened 4 years ago

rochatjl commented 4 years ago

in private function requestAuthorization() {

596 $response_type = 'code'; => forces authorization code flow even if you specified :

$this->client->setResponseTypes(['token', 'id_token']);
$this->client->setAllowImplicitFlow(true);

why not use instead : $response_type = $this->responseTypes;
and if empty use 'code'

rochatjl commented 4 years ago

better ? line 596 if ($this->allowImplicitFlow) $response_type = $this->responseTypes; else $response_type = 'code';