jumbojett / OpenID-Connect-PHP

Minimalist OpenID Connect client
https://github.com/jumbojett/OpenID-Connect-PHP
Apache License 2.0
606 stars 363 forks source link

Split up authenticate() into individual actions to allow per-action use #436

Open bartgloudemans opened 3 weeks ago

bartgloudemans commented 3 weeks ago

Allowing the caller to call the magical request handler authenticate or to have more control over the process and call the individual actions themself

ricklambrechts commented 2 weeks ago

Thanks for this PR! Overall I think this is a nice improvement that enables more extensibility.

This change also adds the ability to use specific $_GET or $_POST params instead of the $_REQUEST param by just overriding the updated authenticate function.

I noticed that the updated code has tabs instead of spaces, mabye you can update the code to use spaces.

bartgloudemans commented 2 weeks ago

@ricklambrechts Thanks for the feedback and sorry about the tabs, will correct those