search

jumoog / intro-skipper

Fingerprint audio to automatically detect and skip intro/credit sequences in Jellyfin
https://discord.gg/AYZ7RJ3BuA
GNU General Public License v3.0
405 stars 22 forks source link

Update Css #167

Closed rlauuzo closed 1 month ago

rlauuzo commented 1 month ago

grafik grafik

Allows for custom accent color and border radius.

AbandonedCart commented 1 month ago

That looks good! Also a fan of em over px for flexibility.

rlauuzo commented 1 month ago

Should we use the emby-button instead?

jumoog commented 1 month ago

What's the difference?

rlauuzo commented 1 month ago

emby-button is general purpose button for Jellyfin. paper-icon-button-light is for displaying icons. You can test it here. https://github.com/rlauuzo/intro-skipper/releases/tag/10.9%2Fvtest

AbandonedCart commented 1 month ago

I think the paper one was originally used for the secondary effects. It’s a weird design in general, so a button meant to be a button will almost definitely be better for the purpose.

jumoog commented 1 month ago

Better matches UI style

rlauuzo commented 1 month ago

Ready, if no one else has feedback.

AbandonedCart commented 1 month ago

Nothing looks out of place, so I've got nothing.

I'm not sure if anyone will run into issues dropping all the moz and friends compatibility, but a lot of that is for really old browsers.

jumoog commented 1 month ago

Lgtm

jumoog commented 1 month ago

ready?

rlauuzo commented 1 month ago

Yeah, but if you merge, you'll probably have to change document.querySelector("#skipIntro") to document.querySelector("#skipIntro .emby-button") in https://github.com/jumoog/intro-skipper/pull/170

barrio5 commented 1 month ago

I like the styling of the buttons and I would like the same style for the skip notification messages, so they all share the same design priciples. Is that possible?

jumoog commented 1 month ago

This has nothing to do with this plugin. What you are looking for is called jellyfin theme. Please look at the Jellyfin Forum or List on Githbub