search

jump-cellpainting / 2024_Chandrasekaran_NatureMethods

BSD 3-Clause "New" or "Revised" License
55 stars 11 forks source link

Drop `target` column in metadata to avoid confusion? #93

Open shntnu opened 1 week ago

shntnu commented 1 week ago

@niranjchandrasekaran Ok to drop the target column in https://github.com/jump-cellpainting/2024_Chandrasekaran_NatureMethods/blob/0d64eabc8ca665b2c75a49a03bcdbd97924b1385/metadata/external_metadata/JUMP-Target-1_compound_metadata_targets.tsv?

That has caused confusion in the past; IIUC we only used target_list in all the results presented in the final version of the paper.

niranjchandrasekaran commented 1 week ago

IIUC we only used target_list in all the results presented in the final version of the paper.

That's correct.

I wouldn't drop the target column. But I am ok renaming it because this is the column that determined which genes were chosen for the genetic perturbation experiments, and it would be good to have a record of that.

shntnu commented 6 days ago

Ah got it. I did replace it in https://github.com/jump-cellpainting/JUMP-Target/pull/36/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5; I'm guessing that's ok? (because it matters for the paper repo)

niranjchandrasekaran commented 6 days ago

I'm guessing that's ok? (because it matters for the paper repo)

I guess that's fine. The original files are still in jump-cellpainting/jump-cellpainting (internal link) so we can always find the target column there.