search

jump-dev / Convex.jl

A Julia package for disciplined convex programming
https://jump.dev/Convex.jl/stable/
Other
567 stars 121 forks source link

Add license headers #606

Closed odow closed 5 months ago

odow commented 5 months ago

I'll comment in-line with a few things.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.83%. Comparing base (484f853) to head (261b93c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #606 +/- ## ======================================= Coverage 97.83% 97.83% ======================================= Files 86 86 Lines 5035 5035 ======================================= Hits 4926 4926 Misses 109 109 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericphanson commented 5 months ago

I think I was probably too conservative with license stuff, added too many. This looks good!