z = Variable()
p = satisfy(z == atom(x))
solve!(p)
@test evaluate(z) == evaluate(atom(x))
for each atom, with appropriate sizes and number of args etc (and isapprox instead of ==).
This would check that the conic form has a valid path for constant expressions and agrees with evaluate. (Possibly we can cut out the solver somehow from this test?).
Came up in #613 where I had an incomplete implementation that passed existing tests, which didn’t handle the constant case correctly.
odow
commented
2 months ago
We should test
for each atom, with appropriate sizes and number of args etc (and isapprox instead of ==).
This would check that the conic form has a valid path for constant expressions and agrees with evaluate. (Possibly we can cut out the solver somehow from this test?).
Came up in #613 where I had an incomplete implementation that passed existing tests, which didn’t handle the constant case correctly.