Closed ericphanson closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.79%. Comparing base (
ac382bb
) to head (2088bb1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Okay. I've simplified the test handling, but now it requires #623
Urgh. I borked that. Let's just wait and I'll rebase on master
.
Addresses https://github.com/jump-dev/Convex.jl/issues/616 in the real case only. In the complex case unfortunately I found many issues, too many to address in this PR. Some would be addressed similarly to the change for
new_conic_form!(context::Context{T}, e::RelativeEntropyAtom)
, whereGenericConstraint
nicely handles the constant case, but directMOI_add_constraint
does not.(The issues here are not really correctness bugs, but rather errors one would get if for some reason they had constant values rather than variables in some atoms, such as if you
fix!
'd a variable).