search

jump-dev / Convex.jl

A Julia package for disciplined convex programming
https://jump.dev/Convex.jl/stable/
Other
559 stars 119 forks source link

Report compilation stats when silent_solver=false #633

Closed odow closed 2 months ago

odow commented 2 months ago

x-ref https://github.com/jump-dev/Convex.jl/pull/631/files#r1591749619

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.82%. Comparing base (de4bff2) to head (e7c45bc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #633 +/- ## ======================================= Coverage 97.82% 97.82% ======================================= Files 88 88 Lines 5141 5144 +3 ======================================= + Hits 5029 5032 +3 Misses 112 112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericphanson commented 2 months ago

This seems good to me. Currently silent_solver just sets MOI.Silent; if the user set MOI.Silent themselves on the optimizer, we would still print here. I think maybe that's fine? The other thing is that silent_solver emphasizes the solver part, and this isn't exactly the solver. I wonder if we want to deprecate silent_solver to silent and print this whenever silent==false.

odow commented 2 months ago

We could deprecate silent_solver in a different PR.

I think this info might actually spur people to report performance issues, particularly if it takes a small time to solve but a long time to compile.