Closed ericphanson closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.96%. Comparing base (
68e9efc
) to head (90016a6
). Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
IMO it is kind of goofy, and doesn't match how the rest of Julia works which can make it confusing. There is also not much of a mathematical or translation purpose; I've never seen constraints written that way in a paper.
Also, I've updated the
Problem
constructors to be less picky about the types, which makes manual construction of the constraints vector (likeconstraints = []; push!(...)
less annoying). I suspect thep = minimize(...); p.constraints += ...
thing was partly to make the constructors work.Lastly, I fixed a small bug: the field
constraints
was typed as anArray
, which meant you could construct aMatrix{Constraint}
as theconstraints
field inProblem
, which would then break the new printing code. Here I've typed it as aVector
.