search

jump-dev / Convex.jl

A Julia package for disciplined convex programming
https://jump.dev/Convex.jl/stable/
Other
557 stars 119 forks source link

Rename GenericConstraint into Constraint and remove abstract type #665

Closed blegat closed 1 month ago

blegat commented 1 month ago

This is the last breaking change I'd like to make until v0.16

odow commented 1 month ago

So this has the potential to be quite breaking. Is anyone writing new constraints in the wild?

ericphanson commented 1 month ago

I think it is unlikely; I just checked the 12 registered packages that use Convex.jl (via https://juliahub.com/ui/Packages/General/Convex), and none of them seem to. Also, I don't think it was ever documented how to construct a new Constraint type.

odow commented 1 month ago

Okay, then I'm :+1: for this

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.04%. Comparing base (8ad02eb) to head (d268e90). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #665 +/- ## ========================================== + Coverage 97.94% 98.04% +0.09% ========================================== Files 89 89 Lines 5165 5160 -5 ========================================== Hits 5059 5059 + Misses 106 101 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.