search

jump-dev / Convex.jl

A Julia package for disciplined convex programming
https://jump.dev/Convex.jl/stable/
Other
557 stars 119 forks source link

Deprecate `silent_solver` to `silent` #670

Closed ericphanson closed 1 month ago

ericphanson commented 1 month ago

Since now it is being used for Convex's verbosity also (printing the formulation time). It is also shorter which I like. I also set it to turn off the warning for non-optimal solutions for consistency and to reduce clutter in test logs.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.11%. Comparing base (d19955e) to head (2c6937e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #670 +/- ## ========================================== + Coverage 98.09% 98.11% +0.02% ========================================== Files 89 89 Lines 5150 5157 +7 ========================================== + Hits 5052 5060 +8 + Misses 98 97 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericphanson commented 1 month ago

IMO it would be good for this to be part of v0.16.0 to reduce churn. But it isn’t breaking so it could go in after.