Allow options to be passed to ECOS via kwargs.

jump-dev / ECOS.jl

A Julia interface to the ECOS conic optimization solver

https://github.com/embotech/ecos

Other

41 stars 17 forks source link

Allow options to be passed to ECOS via kwargs. #13

Closed iamed2 closed 9 years ago

iamed2 commented 9 years ago

I bumped the version number because I have no way to test that this works on 0.2 (and it probably doesn't). Feel free to change it if you can test on 0.2.

coveralls commented 9 years ago

Coverage increased (+0.16%) when pulling ec97ae8baf2d49c587691cc79912b8cf36d9aafc on invenia:master into 0bc26dea8994093b31f9d6920fb81a2faabf1fb5 on JuliaOpt:master.

IainNZ commented 9 years ago

Oh wow this is a beautiful pull request, really great work! I was going to do something lazy that would have required hard-coding all the fields in Csettings into the setup function, this is way cooler.

joehuchette commented 9 years ago

I don't think breaking 0.2 compat is a big deal. Also, :100: for new tests!

IainNZ commented 9 years ago

Yeah I didn't even know we still had 0.2 in there

IainNZ commented 9 years ago

I'm going to add some documentation in the README and then tag a new ECOS.jl version

iamed2 commented 9 years ago

Thanks @IainNZ ! Glad to help.