search

jump-dev / ECOS.jl

A Julia interface to the ECOS conic optimization solver
https://github.com/embotech/ecos
Other
41 stars 17 forks source link

Implement MOI.default_cache #137

Closed blegat closed 2 years ago

blegat commented 2 years ago

Still need to merge fixes in MOI that were detected in this PR and wait for an MOI release that include them:

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (72dbd92) into master (d899fd9) will decrease coverage by 2.35%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   81.20%   78.84%   -2.36%     
==========================================
  Files           3        3              
  Lines         250      260      +10     
==========================================
+ Hits          203      205       +2     
- Misses         47       55       +8
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 78.76% <33.33%> (-1.24%) :arrow_down:
src/MOI_wrapper/permuted_exponential_cone.jl 72.72% <75.00%> (-16.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d899fd9...72dbd92. Read the comment docs.

odow commented 2 years ago

@blegat why are we getting this ZeroBridge error when we weren't without the OptimizerCache?