search

jump-dev / ECOS.jl

A Julia interface to the ECOS conic optimization solver
https://github.com/embotech/ecos
Other
41 stars 17 forks source link

Fixes for Julia v1.0 #74

Closed blegat closed 6 years ago

blegat commented 6 years ago

The MPB quad tests have been disabled on Julia v1.0 because of https://github.com/JuliaOpt/MathProgBase.jl/pull/218

codecov-io commented 6 years ago

Codecov Report

Merging #74 into master will decrease coverage by 0.2%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #74      +/-   ##
=========================================
- Coverage   91.81%   91.6%   -0.21%     
=========================================
  Files           4       4              
  Lines         440     441       +1     
=========================================
  Hits          404     404              
- Misses         36      37       +1
Impacted Files Coverage Δ
src/MPBWrapper.jl 94.36% <100%> (ø) :arrow_up:
src/MOIWrapper.jl 88.44% <85.71%> (-0.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95e6606...321e695. Read the comment docs.

mlubin commented 6 years ago

Is anything else broken in MPB or should I tag a new release?

blegat commented 6 years ago

No changes are needed for CSDP/SemidefiniteModels and this is the only change needed for ECOS so tagging a release now is a good idea

mlubin commented 6 years ago

Done https://github.com/JuliaLang/METADATA.jl/pull/17439